A Cultural Approach to Pull Requests
A pull request can just be the start…
A code review is a subjective analysis of work completed. The purpose of a code review is to ensure that coding standard and quality is upheld when a Pull Request (PR) is merged into a release or master branch.
This seems (other than that key word, subjective) like a simple, mechanical process that ensures that code is good. In reality the process is a human one, and therefore can be more complex than might initially may be assumed.
Set up for success
Before starting the review process, the following can be put into place to ensure the success of the Code Review system as a whole:
Linter
A Linter such as SwiftLint helps the whole team conform to the same coding standards. Having an agreed set of Linting rules (and sticking to them) is an essential part of working towards a great software product, and a productive working environment. By automating part of the process Code Reviews become a faster and more intellectually stimulating process. SonarQube can offer similar functionality for code quality, although to be clear no automated system offers the set of benefits that a good Code Review will give.
